search

dronekit / sphinx_3dr_theme

Sphinx 3DR Theme based on sphinx_rdt_theme
3 stars 6 forks source link

Bullets have some issues #20

Closed hamishwillee closed 9 years ago

hamishwillee commented 9 years ago

This still has some issues following #5 being closed.

  1. Odd misalignment - more visible magnified

image

image

  1. The next lines are indented back which to my mind looks really odd. Shouldn't subsequent lines align with the first line?

image

hamishwillee commented 9 years ago

The size of the bullet also looks a little big to me, compared to the text size.

kaitlynhova commented 9 years ago

Hey @hamishwillee good eye! I fixed it in this branch: https://github.com/3drobotics/sphinx_3dr_theme/tree/scroll-to-fixes

Does that work for you? I like the bullets being super large for legibility and design eye reasons. @mrpollo , do you want them to be smaller?

hamishwillee commented 9 years ago

Hi @kaitlynhova

I can't view or build this yet, because I haven't got that working (@mrpollo plans to do a vagrant to simplify this). Can you cut-paste an example here for me.

I do agree re bullets being big. Perhaps the font for the text is just a little small relatively though.

Cheers H

kaitlynhova commented 9 years ago

Hey! Sorry for the delay, I didn't realize you couldn't view the changes. Here is a screenshot of the new bullets:

screen shot 2015-06-15 at 2 10 36 pm

Does that work for you? I also made them smaller ~

hamishwillee commented 9 years ago

@kaitlynhova Looks good to me! Thank you.

kaitlynhova commented 9 years ago

@hamishwillee check it out on production, now.

hamishwillee commented 9 years ago

@kaitlynhova I am VERY happy with the ordered and un-ordered list appearance now. Just the right amount of space. Tested on chrome only.