search

drood87 / tea_cozy_website

Assessment for Codecademy Course. Manifesting skills in Flexbox, CSS and overall Layout for static Websites
MIT License
0 stars 0 forks source link

CSS #2

Open Axkaban opened 6 years ago

Axkaban commented 6 years ago

were you having trouble displaying some styles or what made you decide using two gobal selectors https://github.com/drood87/tea_cozy_website/blob/master/assets/style.css#L1-L9 In general you should be on just using the html selector if you want to apply those styles from the header to the body, or the body selector if all you are interested is in styling what is inside.

Again, thank you for the comments! https://github.com/drood87/tea_cozy_website/blob/master/assets/style.css#L11-L13

Great way to select a child of element https://github.com/drood87/tea_cozy_website/blob/master/assets/style.css#L84

Nice grouping and following style guidelines https://github.com/drood87/tea_cozy_website/blob/master/assets/style.css#L104-L105

drood87 commented 6 years ago

To be honest #L1-L9 were out of habit I think. Haven't really thought about it and just took html and body selector for global styles. Will change my habit to just either body or the html selector.

Thank you for pointing that out!! :)