search

dropbear-software / todart

Example full stack Dart research project of a very over engineered Todo list application
MIT License
0 stars 1 forks source link

CloudResourceIdentity is unable to verify identifiers produced from the toReadableString method #20

Closed mark-dropbear closed 3 years ago

mark-dropbear commented 3 years ago

The following test is currently failing. Suspect the bug lies somewhere in this method

https://github.com/dropbear-software/todart/blob/resource-id/common/test/types/cloud_resouce_identiy_test.dart#L34

test('Validates its own toReadableString method correctly', () {
  final identity = CloudResouceIdentity();
  expect(CloudResouceIdentity.isValid(identity.toReadableString()), isTrue);
});
mark-dropbear commented 3 years ago

Also something worth remembering is that previously there were exceptions happening before I started swallowing them here https://github.com/dropbear-software/todart/blob/resource-id/common/lib/src/types/cloud_resource_identity.dart#L82 where the Base32 library I am using said that some characters were not valid.