dropbox / SwiftyDropbox

Swift SDK for the Dropbox API v2.
MIT License
685 stars 207 forks source link

Alamofire? But why? #200

Closed atljeremy closed 7 months ago

atljeremy commented 6 years ago

As a best practice, when writing client libraries, you should use the internal core API's that are provided by the platform to not force additional lib requirements on those using your lib. In some cases there's no avoiding it, but in the case of networking, this can and should be avoided. Not everyone is using Alamofire and doesn't want to add the additional dependency/bloat to their app.

Apple has made it easier and easier to write solid/stable networking code using the built in API's like URLSession. Is there something you're using in Alamofire that you can't get by using the platform provided networking API's? Hopefully the answer is no being that Alamofire is just a wrapper around URLSession. I'd love to see this lib updated to use the platform provided networking API's. Hell, if I had more time, I'd love to help with that effort.

Here are some articles/other libs that highlight this concept:

greg-db commented 6 years ago

Thanks for writing this up! I'm sending this along to the team.

slizeray commented 6 years ago

100% agree with @atljeremy !

FabienLydoire commented 5 years ago

@greg-db what's the status on this issue ? The dependency to Alamofire is segregated to the file DropboxTransportClient.swift. What's the technical reason for using Alamofire over URLSession ?

greg-db commented 5 years ago

@FabienLydoire This is still open with the team, but unfortunately I don't have any update or additional information to share.

ioskunal commented 4 years ago

Hey @FabienLydoire , @greg-db do we have any plans of removing Alamofire from the library?

greg-db commented 4 years ago

@greg-db I don't have any news or plans for this request to share. I'll reply here if/when I do.

wilwet commented 4 years ago

Please remove Alamofire dependency or keep it current. +1 either case.

greg-db commented 4 years ago

@wilwet Thanks for the feedback!

alak commented 3 years ago

Ping! Can you remove alamofire please ?

greg-db commented 3 years ago

@alak Thanks for checking in. I don't have an update on this unfortunately though. I'll follow up here if/when I do.

ChrisPearce commented 3 years ago

Is a change to remove the AlamoFire dependency currently on the roadmap?

greg-db commented 3 years ago

@ChrisPearce I don't have any news to share on this.

greg-db commented 3 years ago

The request to remove Alamofire entirely is still open, but for reference SwiftyDropbox now supports Alamofire 5 as of v8.0.0.

ChrisPearce commented 1 year ago

Is there anymore news on whether the dependency on AlamoFire will be removed?

slizeray commented 1 year ago

Good question! This request is open since almost 5 years...I guess it gives us some strong indication? LOL

greg-db commented 1 year ago

I don't have any update on this right now.

greg-db commented 1 year ago

We've released a beta version of SwiftyDropbox with some significant updates, such as to remove the dependency on Alamofire. You can find more information here: https://www.dropboxforum.com/t5/Dropbox-API-Support-Feedback/Beta-version-of-major-SwiftyDropbox-update-available/td-p/695441

FabienLydoire commented 1 year ago

Great release @greg-db ! Congrats to the Team šŸ‘šŸ»

julianlocke commented 7 months ago

The above mentioned beta has been promoted to stable release. Read more about it here: https://www.dropboxforum.com/t5/Dropbox-API-Support-Feedback/Major-SwiftyDropbox-update-available/td-p/737816