'let' properties are implicitly 'final'; use 'public' instead of 'open'

[slizeray]

With XCode 10, there are 1640 this warning...

[greg-db]

Thanks for the report! I'll ask the team to clean that up.

[TomMajor]

Would be great if this could be fix soon. I get like 1651 warnings, the quick view warnings symbol on the right side of the project title bar reads 999+ warnings and this will "mask" warnings in other modules on quick view. Please make SwiftyDropbox Xcode 10 / Swift 4.2 compatible. Thanks,

[greg-db]

Thanks for the feedback! I'll send this note along to the team about this.

[wilwet]

Thnx, Any idea when this is fixed.

[greg-db]

No, I'm afraid I can't offer a timeline for this.

[wilwet]

No problem, the code works fine but it gives an uneasy feeling :)

[marcelmendesfilho]

Just replaced 'open let' with 'public let' to solve those warnings. If this can be a solution, let me know how to open a PR (I'm kinda new here). My repo is https://github.com/marcelmendesfilho/SwiftyDropbox

[greg-db]

@marcelmendesfilho It sounds like that is likely the correct solution, however note that the SDK is generated, so the fix would likely need to be implemented in the generator itself. We do welcome pull requests: https://github.com/dropbox/SwiftyDropbox/pulls

[TomMajor]

I think the use of 'public' instead of 'open' will fix the warnings, but since they are in so many places and Apple released a major update to Xcode and Swift, shouldn't the creator of SwiftyDropbox fix it asap to make the framework ready for Xcode 10 / Swift 4.2 instead of waiting for pull-requests? Many developers have to switch to newest Xcode fast because of needed support for new iOS, it's always the same every year in September.. :unamused:

[slizeray]

Such a trivial fix and can't offer a timeline.... Who can say that this framework is maintained?

[slizeray]

With Xcode 10.1..., please fix....

[greg-db]

Thanks for the reminder! I'll check in with the team on this.

[ZakiRKaram]

I can't believe we are dealing with Dropbox. More than a month and still we are waiting for a small update to fix the problem. Come on Dropbox.

[slizeray]

@ZakiRKaram Sorry we are waiting since September 4, that is 2 months... for a trivial update.... Beyond any understanding....

[TomMajor]

As mentioned earlier in this thread, please make SwiftyDropbox Xcode 10 / Swift 4.2 compatible. What kind of team is working on this which can't fix this in two months? I really don't want to be disrespectful, but honestly from a company like Dropbox one really would assume a bit faster and more professional support, I don't understand this either... If you have problems with the work on this repository or think about giving up support for new versions, it would be helpful to communicate this so that developers can adjust their plans accordingly. Thanks

[greg-db]

Thanks for the feedback everyone! I'll pass this along to the team.

[slizeray]

@greg-db Either you are a tchat bot, or please go beyond this rhetoric, we expect much more than this now. Thanks.

[greg-db]

@slizeray I'm certainly a real person, but I can't make promises on behalf of the team as to when they'll be able to prioritize any particular task. I wouldn't want to do so and accidentally lie, in case the team's timeline for any particular work changes. Apologies I can't offer more specific guidance!

[slizeray]

@greg-db Please escalate this issue and ask the team lead to provide explanations why the community is waiting so long for such a trivial task and to give a specific guidance. Like @TomMajor I don't want to be disrespectful, but we are far away from professional support standards. Thanks!

[greg-db]

@slizeray No problem, I'll escalate this further now.

[flexfrank]

@greg-db You said:

the SDK is generated, so the fix would likely need to be implemented in the generator itself. We do welcome pull requests

I created a pull request for that generator: https://github.com/dropbox/stone/pull/119 Nine days have passed...

What's the problem? All you (or other dropbox guys) have to do is to PUSH THE MERGE BUTTON.

[greg-db]

@flexfrank Thanks! It looks like the team did just merge https://github.com/dropbox/stone/pull/119 . There are a few more steps to get the updated/regenerated code released. I'll follow up here once that's done.

[greg-db]

This is fixed now in the latest release.

[slizeray]

@greg-db Thanks. Is it on purpose that the framework has been ported to Swift 4.0, and not Swift 4.2?

[slizeray]

[slizeray]

@greg-db There are also 3 remaining warnings (even in Swift 4.0)

[greg-db]

@slizeray Yes, the work for Swift 4.2 has not been completed. That's open as #237 .

The characters warning is open as #207 .

I don't believe there's an open issue for the deprecated '!' usage warning, but I'll ask the team to clean that up as well.

[TomMajor]

The 1651 warnings are fixed now, that is great news. The other 2 errors (UIAlertController) and 3 warnings need still a fix, but the errors are easy to patch in a project for the meantime. Hope they get fixed soon. Anyway, thanks for showing us that this repository is still alive :)

[slizeray]

@greg-db Are you really waiting for people complaining before updating this framework for each new Swift release? This is a shame. Please update to Swift 5.0 and XCode 10.2.1

[greg-db]

@slizeray Thanks for the feedback. Can you elaborate on what isn't working for you specifically? I tried this library with Swift 5 and Xcode 10.2 for #249 without issue. If it's not working as expected, please open an issue with details. Thanks in advance!

[slizeray]

I expect SwiftDropbox to compile as Swift 5. This is not the case at the moment, it is compiled as Swift 4.2.

I am sorry, this is unacceptable to wait for your users asking to support the latest Swift version. You should do it automatically. It happens again and again. I am not going to open an issue. I expect Dropbox to maintain professionally this framework. This topic has already been discussed at length in this thread.

[greg-db]

@slizeray Thanks for clarifying! I'll ask the team to make that update.

And thanks again for the feedback. I'll also bring this up with the team.

[o-zaporozhchenko]

just use inhibit_all_warnings! to silence warnings. As soon it doesn't block ur usage of a framework, there is no real problem.

[greg-db]

SwiftyDropbox has been updated to Swift 5 in the latest release.