search

dropbox / dbx_build_tools

Dropbox's Bazel rules and tools
Other
208 stars 36 forks source link

Added brief introduction to using external packages #29

Open jake-arkinstall opened 3 years ago

jake-arkinstall commented 3 years ago

Partially addresses #27, and related to #5

I'm a new user of this project, and I found it rather difficult to understand how external packages were used. After finding issue #5, and seeing some explanation, as well as with help from @jsharpe on the Bazel/Python slack channel, I believe that I understand the process.

I figured that that I should assist by adding some instructions to README.md I don't know if my approach is the intended approach, so I'm happy to make any changes (or for you to make any changes) to suit the intended use. Either way, I think such an explanation is vital for newcomers to utilize this project.

jake-arkinstall commented 3 years ago

I agree with the above comments and have updated my PR with the requested changes.

I am likewise happy to address any further concerns.

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.