dropbox / dbx_build_tools

Dropbox's Bazel rules and tools
Other
208 stars 36 forks source link

updated README.md to make the tutorial work #35

Open zyxue opened 3 years ago

zyxue commented 3 years ago

I find I need to make these edits to make the tutorial work.

for the i.encode('utf-8') part, if not specified, the error would've been

Traceback (most recent call last):
  File "wsgiref/handlers.py", line 138, in run
    self.finish_response()
  File "wsgiref/handlers.py", line 184, in finish_response
    self.write(data)
  File "wsgiref/handlers.py", line 279, in write
    assert type(data) is bytes, \
AssertionError: write() argument must be a bytes instance
benjaminp commented 3 years ago

Thanks. I think it would make the most sense to only support Python 3. So, add python2_compatible = False where necessary.

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.