dropbox / dbx_build_tools

Dropbox's Bazel rules and tools
Other
209 stars 37 forks source link

Disable thin_lto when calculating build flags #41

Closed jsharpe closed 3 years ago

jsharpe commented 3 years ago

Bazel's thin_lto flags assume that the compilation is occurring in multiple steps including an indexing step. This assumption is not valid for compilation within go or python and so remove the thin_lto feature from the list of supported features when calculating flags.

jhance commented 3 years ago

Looks good will merge tomorrow. (This is now merged, will be released whenever we do an export)