search

dropbox / dbxcli

A command line client for Dropbox built using the Go SDK
Other
1.06k stars 99 forks source link

Update golumns package to latest version - major bug fix #44

Closed grantseltzer closed 8 years ago

grantseltzer commented 8 years ago

It came to my attention that golumns was causing an index out of bound error when trying to ls an empty directory. I've patched the library and this PR will update the vendoring directory to include this patch.

If someone can please confirm on their system that running ls on an empty directory does in fact cause an error for them before this patch and doesn't after I'd greatly appreciate it.

Sorry about not catching this earlier!

Signed-off-by: Grantseltzer grantseltzer@gmail.com

diwakergupta commented 8 years ago

Confirmed that it does error out, thanks for catching that @GrantSeltzer -- need to figure out a good way of "unit" testing dbxcli to prevent these in future. Any ideas?

grantseltzer commented 8 years ago

@diwakergupta hmmm, It'll be tricky but definitely needs to be done. I guess we'd need some way of mocking the dropbox api. I can definitely start coming up with some stuff in the next couple of days :)!

Also thanks for the quick merge!

waits commented 8 years ago

👍 for unit tests. I'm willing to help out as well.