dropbox / dbxcli

A command line client for Dropbox built using the Go SDK
Other
1.06k stars 99 forks source link

Add multiple args to rm #49

Closed grantseltzer closed 8 years ago

grantseltzer commented 8 years ago

This just adds a loop around the functionality of rm to now support multiple arguments.

Link to example usage: http://i.imgur.com/Fm71rR6.png

diwakergupta commented 8 years ago

FYI the image link doesn't work

grantseltzer commented 8 years ago

@diwakergupta updated link, not sure why that was happening

grantseltzer commented 8 years ago

@diwakergupta I've updated this PR to now validate and check meta data before removing. It will fail if any arguments are invalid and nothing will be removed.

diwakergupta commented 8 years ago

Thanks @GrantSeltzer . One thing I want to start doing is wherever we have multiple file operations, we can easily parallelize them, especially in Go via goroutines. That should help w/ performance, as the number of args increase.

grantseltzer commented 8 years ago

Excellent idea! I'll work on that for future contributions.

Thanks for the merge @diwakergupta!