Fix destination issue, add multiple args and concurrent execution to the `put` command

[grantseltzer]

This adds the ability to specify multiple arguments to the put command which are then executed using the go mechanism.

On top of this, it fixes an issue that I brought up in #52 in which the 'destination' could be specified but wasn't working the way the description described it. Under my proposed changes the user can specify any number of arguments to upload. If a destination isn't specified (using the --destination flag) then the files will be uploaded to the root of the users dropbox directory.

The issue that is still being posed that may want to be addressed before this is merged is that having many arguments cause 'too many upload attempt' errors to occur. Not sure if this should be handled at this level or at the sdk level. Regardless I'd like to resolve it.

Signed-off-by: grantseltzer grantseltzer@gmail.com

[paultopia]

Just poking my head in here from the issue #52 --- does this also resolve the behavior mentioned in that threat where if the target is a directory, rather than saving uploaded file to that directory, it overwrites that directory altogether with the file? If not, should that be a separate issue/PR? (This seems like a particularly dangerous gotcha. I'm imagining hundreds of people entering commands like dbxcli put logfile.txt some/critical/directory and then watching their data disappear...

[grantseltzer]

That's a very good call out, let me do some manual testing and confirm it works safely. If a fix is needed it definitely should be part of this PR.

On Sep 28, 2016 11:11 AM, "Paul Gowder" notifications@github.com wrote:

Just poking my head in here from the issue #52 https://github.com/dropbox/dbxcli/issues/52 --- does this also resolve the behavior mentioned in that threat where if the target is a directory, rather than saving uploaded file to that directory, it overwrites that directory altogether with the file? If not, should that be a separate issue/PR? (This seems like a particularly dangerous gotcha. I'm imagining hundreds of people entering commands like dbxcli put logfile.txt some/critical/directory and then watching their data disappear...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dropbox/dbxcli/pull/54#issuecomment-250196865, or mute the thread https://github.com/notifications/unsubscribe-auth/AKWrhUTFqk7VkauYqqBCRF3V0OD8d0KHks5quoOsgaJpZM4KGGfW .

[grantseltzer]

@paultopia Thanks again for the call out, files won't be overwriten, but the error wasn't being handled properly (but is now).

@diwakergupta or @satori Whenever you get a chance to review :+1:

[grantseltzer]

@diwakergupta Do you have any feedback for my most recent comments?

[grantseltzer]

@diwakergupta ping

[diwakergupta]

@GrantSeltzer sorry -- other priorities meant dbxcli was ignored past many weeks! Let me page stuff back in, will review this PR by tomorrow. Thanks for your patience (and contributions)!

[grantseltzer]

@diwakergupta No apology needed, I'm in the middle of finals week so I understand having other priorities! (Also means no rush on this).

[grantseltzer]

@diwakergupta I'd love for development of this to pick back up. Can you take a look at the changes on this?

[connor-baer]

Ping :)

[grantseltzer]

@diwakergupta ping :)

[Still34]

Can we get an update on this ancient issue/PR?

[mbojan]

Almost two years and counting... Any updates?

[diwakergupta]

Hey folks I'm no longer with Dropbox (been 1+ yrs) and I'm not sure what (if anything) Dropbox plans to do with this tool. Sadly maintaining this on my own time has become harder since.

@KarandeepJohar not sure if you're the right person, but perhaps you can tag the right folks.

[mbojan]

I'd rather see it closed by a merge @grantseltzer ;) Why?

[grantseltzer]

I was just tired of looking at this under my PRs tab. Feel free to reopen if you think this project will be brought back and maintained.

On Tue, Jun 29, 2021 at 9:23 AM Michał Bojanowski @.***> wrote:

I'd rather see it closed by a merge @grantseltzer https://github.com/grantseltzer ;) Why?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dropbox/dbxcli/pull/54#issuecomment-870596207, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACS2XBIPJ5EOUHCURT34M4LTVHCM5ANCNFSM4CQYM7LA .

[mbojan]

Too bad :(