search

dropbox / dependency-guard

A Gradle plugin that guards against unintentional dependency changes.
Apache License 2.0
406 stars 15 forks source link

Configuration cache pt1 #57

Closed qwert2603 closed 1 year ago

qwert2603 commented 1 year ago

This PR is the part 1 (first 5 commits) of #51 to simplify reviewing and merging.

  1. more test cases added to be more confident when making large changes and refactoring afterwards.
  2. usage of project property during task's execution (@TaskAction) breaks configuration cache. That's why project.path is now saved while configuring the task in DependencyGuardTreeDiffer.
  3. checks from ConfigurationValidators are now called in tasks's configurationAction instead of @TaskAction to avoid breaking configuration cache (these validations use project property).
  4. gradle version is bumped to 7.5.1.

Like in original PR, changes are split to commits to simplify review.

qwert2603 commented 1 year ago

@handstandsam Hi! Will this PR be helpful to simplify review?

handstandsam commented 1 year ago

Closing since https://github.com/dropbox/dependency-guard/pull/51 was merged.