Closed SimonMarquis closed 1 year ago
We probably should add tests to avoid future regressions.
| "We probably should add tests to avoid future regressions."
What isn't covered? I think because we're on 0.5.x
and haven't cut it yet, ideally we should be adding tests in now. I felt like 0.4.x
ended up being pretty crazy running around trying to fix config cache, so the more tests the better!
--
Thank you for the PR!
The current tests were asserting on the Gradle exception message.
The new version now uses StringBuilder, which makes new lines automatically handled.
Also, I removed the dependency of diffTextWithPlusAndMinusWithColor
on diffTextWithPlusAndMinus
. They now only rely on diffLines
. This makes it more straightforward, as we no longer have to check for "empty" lines and unexpectedly produce a double line break.
Sounds good. Is this ready to merge? Looked fine.
Yup, ready to be merged 👌
The
\n
was added only if the first condition was false because of if/else priorities.is in fact executed as
Closing #94