Property declaration support in interfaces

dropbox / djinni

A tool for generating cross-language type declarations and interface bindings.

Apache License 2.0

2.88k stars 487 forks source link

Property declaration support in interfaces #360

Open ghost opened 6 years ago

ghost commented 6 years ago

In an effort to continue the work in this PR https://github.com/dropbox/djinni/pull/287, I've attempted to address the review comments and ensure the concerns have been addressed. Please review that original PR for more details.

Wherever possible I attempted to inject property-specific accessor information into the methods AST to share code generation. I was unable to do this at the parser level, since different languages have different needs.

xianwen commented 6 years ago

Hi, @MikeNachbaur: I noticed you haven't signed the CLA yet, could you please sign it here: https://opensource.dropbox.com/cla/ Thanks a lot!