search

dropbox / djinni

A tool for generating cross-language type declarations and interface bindings.
Apache License 2.0
2.88k stars 487 forks source link

Improve IDEA plugin #363

Closed ice1000 closed 6 years ago

ice1000 commented 6 years ago

Added:

xianwen commented 6 years ago

Hi, @ice1000: I noticed you haven't signed the CLA yet, could you please sign it here: https://opensource.dropbox.com/cla/ Thanks a lot!

ice1000 commented 6 years ago

@xianwen Thanks for notifying! I've just signed it.

ice1000 commented 6 years ago

Ooops, I've unexpectedly removed some copyrights. Will revert them.

ice1000 commented 6 years ago

Also I've noticed a commonly thrown exception:

Argument for @NotNull parameter 'visibilityContext' of com/dropbox/djinni/ideaplugin/DjinniUtil.findAllExternalFiles must not be null
java.lang.IllegalArgumentException: Argument for @NotNull parameter 'visibilityContext' of com/dropbox/djinni/ideaplugin/DjinniUtil.findAllExternalFiles must not be null
    at com.dropbox.djinni.ideaplugin.DjinniUtil.findAllExternalFiles(DjinniUtil.java)
    at com.dropbox.djinni.ideaplugin.DjinniUtil.findAllExternalTypes(DjinniUtil.java:129)
    at com.dropbox.djinni.ideaplugin.DjinniChooseByNameContributor.getNames(DjinniChooseByNameContributor.java:43)
    at com.intellij.ide.util.gotoByName.ContributorsBasedGotoByModel$1.processInReadAction(ContributorsBasedGotoByModel.java:98)
    at com.intellij.ide.util.gotoByName.ContributorsBasedGotoByModel$1.processInReadAction(ContributorsBasedGotoByModel.java:82)
    at com.intellij.openapi.application.ReadActionProcessor.lambda$process$0(ReadActionProcessor.java:28)
    at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:927)
    at com.intellij.openapi.application.ReadAction.compute(ReadAction.java:47)

Fixed in d3db9fe

ice1000 commented 6 years ago

intellij-plugin.zip

Here's a jar version of the plugin containing the newest changes, and it's renamed to .zip for github uploading convenience.