dropbox / djinni

A tool for generating cross-language type declarations and interface bindings.
Apache License 2.0
2.88k stars 488 forks source link

Problems when update the support lib #391

Closed paulocoutinhox closed 5 years ago

paulocoutinhox commented 5 years ago

Hi,

I have an error after update the support lib:

/Users/paulo/Developer/workspaces/cpp/xxx-library-core/vendor/dependency-djinni-support/support-lib/jni/djinni_support.cpp:270:1: error: use of undeclared identifier 'JniFlags'
  JniFlags::JniFlags(const std::string & name)
  ^
  /Users/paulo/Developer/workspaces/cpp/xxx-library-core/vendor/dependency-djinni-support/support-lib/jni/djinni_support.cpp:274:10: error: use of undeclared identifier 'JniFlags'
  unsigned JniFlags::flags(JNIEnv * env, jobject obj) const {
           ^
  /Users/paulo/Developer/workspaces/cpp/xxx-library-core/vendor/dependency-djinni-support/support-lib/jni/djinni_support.cpp:289:19: error: use of undeclared identifier 'JniFlags'
  LocalRef<jobject> JniFlags::create(JNIEnv * env, unsigned flags, int bits) const {
                    ^
  3 errors generated.
  ninja: build stopped: subcommand failed.

After the update on .cpp file, this error start happen.

Can anyone help me?

artwyman commented 5 years ago

I'd need more details to be helpful here. From the errors, it feels like you might've updated the cpp file but not the hpp file. JniFlags is defined in djinni_support.hpp herehttps://github.com/dropbox/djinni/blob/master/support-lib/jni/djinni_support.hpp#L557

paulocoutinhox commented 5 years ago

Ok. Problem solved. I didnt see the changes on that file on github, because this i dont copy it to the package.

Thanks.