dropbox / djinni

A tool for generating cross-language type declarations and interface bindings.
Apache License 2.0
2.88k stars 488 forks source link

Change djinni's generated Java files to use interfaces #406

Open ggdabuh opened 5 years ago

ggdabuh commented 5 years ago

This pull request is related to https://github.com/dropbox/djinni/issues/390. The idea is to use interfaces rather that classes as, anyway, the marshaling layer is ready for that. This is a breaking change since users will need to update their overrides.

artwyman commented 5 years ago

To be clear for readers, is about using abstract interfaces for generated container types like list and map when used in records, arguments, and returns. This isn't about what Djinni calls interfaces.

A few procedural things:

xianwen commented 5 years ago

Hi, @ggdabuh: I noticed you haven't signed the CLA yet, could you please sign it here: https://opensource.dropbox.com/cla/ Thanks a lot!

artwyman commented 5 years ago

This repo isn't going to be adding any new features so I'm putting this PR on hold.