Fix an issue with parcelable code gen with sets and no lists

dropbox / djinni

A tool for generating cross-language type declarations and interface bindings.

Apache License 2.0

2.88k stars 488 forks source link

Fix an issue with parcelable code gen with sets and no lists #434

Closed 4brunu closed 5 years ago

4brunu commented 5 years ago

This PR fixes https://github.com/dropbox/djinni/issues/408. I added some conditions to only add the import of ArrayList when necessary, avoiding the import duplication.

4brunu commented 5 years ago

@artwyman and @xianwen can you please take a look at this? Thanks

4brunu commented 5 years ago

@artwyman all the issues are now fixed

4brunu commented 5 years ago

@artwyman I also added more unit tests to the parcelable feature to ensure more code coverage to the feature. Let me know if there are some remaining issues.