search

dropbox / djinni

A tool for generating cross-language type declarations and interface bindings.
Apache License 2.0
2.88k stars 488 forks source link

Fix example objc project #438

Closed 4brunu closed 5 years ago

4brunu commented 5 years ago

Xcode 10 doesn't support Swift 3 anymore, so I updated the example project to build again.

artwyman commented 5 years ago

Thanks for addressing this, though I think it might be too early to merge it. Am I right to understand that this issue is specific to Xcode 10.2? I'm able to build the example project with Xcode 10.0 just fine.

I think this PR also makes Xcode 10.2 the minimum requirement, by setting Swift version to 5. I think it may be too early to require that as a minimum. Dropbox is holding at 10.1 for a little while due to the OS version requirements affecting test environments. Maybe it would make sense to merge an alternative PR which increased the Swift version but not all the way to 5.

4brunu commented 5 years ago

@artwyman I just updated this PR, to only update the Swift version to 4.2, which is compatible with Xcode 10.0