Fix old cast style use in generated file and support lib.

dropbox / djinni

A tool for generating cross-language type declarations and interface bindings.

Apache License 2.0

2.88k stars 488 forks source link

Fix old cast style use in generated file and support lib. #453

Open canatella opened 4 years ago

canatella commented 4 years ago

Fixes LLVM warning: use of old-style cast [-Wold-style-cast]

artwyman commented 4 years ago

Can you please re-generate the code for the example and test cases to show the impact of the generator changes? Also please ensure the tests build and pass. You can run make all from the root which will do everything, if you're on a Mac).

canatella commented 4 years ago

There you go! Test are passing now and generated code looks ok.

artwyman commented 4 years ago

Thanks for your effort! This repo is no longer supported by Dropbox and about to be archived. I'm not going to try to merge this PR at the last minute, but I'll leave it open for reference by anyone who encounters the same problem.