dropbox / dropbox-api-content-hasher

Code to compute the Dropbox API's "content_hash"
Other
69 stars 27 forks source link

Modernize dropbox_content_hasher #10

Open richo opened 6 years ago

richo commented 6 years ago

Hi!

I ported this to use more recent crates and features in rust. I had a quick look at the existing test suite, but they look pretty coupled to some deprecated features of the rand crate, so while I made some changes to check that they still compile I wasn't really able to reason about their correctness. Using this in my application though, it generates correct results.

Also, I realise this has been asked before, but can you push this to crates.io? Without putting too finer point on it, I can today push it since nothing is on the name. If nothing else it would be worthwhile for dropbox to camp it to avoid someone else doing the same.

chur

greg-db commented 6 years ago

Thanks for putting this together! I'll ask the team to review this, and to also look into getting this on crates.io.

richo commented 6 years ago

Hey @greg-db did anyone get a chance to have a look at this?

greg-db commented 6 years ago

@richo No, I'm afraid I don't have any update on this.

richo commented 5 years ago

Sorry to nag, but is there any movement here? I have a copy of this in tree of one of my side projects, but it's a little frustrating to have no canonical source.

greg-db commented 5 years ago

@richo No, unfortunately I don't have any progress to report on this.

richo commented 5 years ago

No worries. Thanks for letting me know.

It's been a bit impractical to not have a version available on cargo and to have it in my tree, so I've broken my fork out into https://github.com/richo/dropbox-content-hasher and pushed it to crates.io as dropbox-content-hasher. If Dropbox would like to have the repo or crate name, just let me know and I'd be happy to transfer either/both.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

richo commented 2 years ago

Ok, I signed the CLA. Is there any chance of having this upstreamed?

greg-db commented 2 years ago

Thanks! I can't make any promises myself, but I'll raise this with the team again.