Fix new ASCII encoder, and put behind a flag for testing.

dropbox / dropbox-sdk-obj-c

Official Objective-C SDK for the Dropbox API v2.

MIT License

183 stars 117 forks source link

Fix new ASCII encoder, and put behind a flag for testing. #366

Closed yanks closed 1 year ago

yanks commented 1 year ago

The original update to the ASCII encoder missed a key issue: the space between codepoints 128 -> 256 were encoded by Apple's encoder as octal. This PR corrects this with more tests, a new implementation that covers this case, and an atomically switchable implementation to toggle between them for greater safety in testing. To enable:

DBBaseTransportClient.useFastAsciiEncoding = YES;

CLAassistant commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Jeff Forbes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}