dropbox / dropbox-sdk-python

The Official Dropbox API V2 SDK for Python
https://www.dropbox.com/developers
MIT License
932 stars 317 forks source link

Added _ca_certs property to _SSLAdapter to properly support pickling (broke in SDK v11.33) #440

Closed dennissiemensma closed 2 years ago

dennissiemensma commented 2 years ago

In Dropbox SDK v11.33 PR #385 added a new _ca_certs property to _SSLAdapter.

However, the property is dynamically specified, which breaks unpickling it using pickle.loads():

  AttributeError: '_SSLAdapter' object has no attribute '_ca_certs'

The fix is simple: Define the property instead of dynamically defining it.

Checklist

General Contributing

Is This a Code Change?

Validation

dennissiemensma commented 2 years ago

The Code of Conduct seems broken guys, HTTP 403: https://opensource.dropbox.com/coc/

dennissiemensma commented 2 years ago

I pre-ran the tests on my fork, most succeed, but some integration tests are failing (on purpose?):

greg-db commented 2 years ago

Thanks! I'll ask the team to review this (as well as check on that 403 on the COC).

dennissiemensma commented 2 years ago

Great, thanks!

greg-db commented 2 years ago

This is released in v11.34.0 now. Thanks again!