dropbox / dropbox-sdk-python

The Official Dropbox API V2 SDK for Python
https://www.dropbox.com/developers
MIT License
932 stars 317 forks source link

Fix invalid specifier in `stone` requirement #456

Closed sagarvora closed 1 year ago

sagarvora commented 1 year ago

As mentioned in https://github.com/pypa/pip-audit/issues/445#issuecomment-1363101453:

PEP 440 doesn't say it directly, but the language implies that the .* is only valid on exact comparison operators (e.g. == and !=), nor ordered comparisons (e.g. >=).

In particular, a comparison like >=3.5.* is redundant: it has the exact same meaning as >=3.5.

This is causing pip-audit to fail, like so: https://github.com/frappe/frappe/actions/runs/3811860090/jobs/6484759800#step:4:183

Checklist

General Contributing

Is This a Code Change?

Validation

greg-db commented 1 year ago

Thanks for sharing this! I'll ask the team to review this.

barredterra commented 1 year ago

I just spent an hour trying to solve this problem. But of course @sagarvora is weeks ahead 😁

sagarvora commented 1 year ago

@greg-db Any update?

greg-db commented 1 year ago

@sagarvora This is still open with the team, but I don't have an update on it yet.

sderickson commented 1 year ago

Hmm, the checks aren't running for this PR for some reason. Might try adding another commit just to get things going. Will pick at it also.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

sagarvora commented 1 year ago

Hi @sderickson,

Thanks for approving the PR.

Edit: Checks are running now. Integrations tests are failing -probably because secrets are only accessible by Dropboxers.

codecov[bot] commented 1 year ago

Codecov Report

Merging #456 (c87d4f7) into main (9895d70) will decrease coverage by 0.58%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   64.26%   63.69%   -0.58%     
==========================================
  Files          31       31              
  Lines       52609    52609              
  Branches     3841     3841              
==========================================
- Hits        33810    33510     -300     
- Misses      18638    19064     +426     
+ Partials      161       35     -126     
Flag Coverage Δ
integration ?
unit 63.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagarvora commented 1 year ago

@sderickson Can we release this please? It should fix #458 and close #464.

sagarvora commented 1 year ago

@sderickson The release v11.36.1 doesn't show on PyPI. Did you miss a step?

greg-db commented 1 year ago

@sagarvora Thanks for the note. That release has not been successfully added on PyPI. We'll follow up once we have an update.

ghane commented 1 year ago

Hi, could you please push this to PyPi? I am trying to install a downstream dependant, and this is making that uninstallable.

Thank you

greg-db commented 1 year ago

@ghane Thanks for the note! This is open with the team. I'll follow up here once that's published to PyPI.

greg-db commented 1 year ago

v11.36.2 is now published on PyPI.