search

dropbox / dropbox-sdk-python

The Official Dropbox API V2 SDK for Python
https://www.dropbox.com/developers
MIT License
930 stars 318 forks source link

Stop providing a hardcoded CA bundle #489

Closed maxbelanger closed 3 months ago

maxbelanger commented 3 months ago

The SDK no longer provides a CA bundle to verify SSL connections. This also allows us to remove the runtime dependency on pkg_resources and thus setuptools.

The ca_certs parameter is still supported, so users can pin with their own CA bundle if they so choose. Otherwise, the default verification mechanism in the requests library now applies (this uses certifi and/or system certificates, depending on the configuration).

Improves integration tests to cover both scenarios (i.e. when a bundle is provided, and when one isn't).

Checklist

General Contributing

Is This a Code Change?

Validation

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.26%. Comparing base (75596da) to head (d5ee9c8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #489 +/- ## ======================================= Coverage 64.26% 64.26% ======================================= Files 31 31 Lines 52609 52606 -3 Branches 3841 3841 ======================================= + Hits 33807 33808 +1 + Misses 18641 18638 -3 + Partials 161 160 -1 ``` | [Flag](https://app.codecov.io/gh/dropbox/dropbox-sdk-python/pull/489/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dropbox) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/dropbox/dropbox-sdk-python/pull/489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dropbox) | `64.17% <100.00%> (+<0.01%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/dropbox/dropbox-sdk-python/pull/489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dropbox) | `63.70% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dropbox#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.