dropbox / dropbox-sdk-python

The Official Dropbox API V2 SDK for Python
https://www.dropbox.com/developers
MIT License
930 stars 318 forks source link

Remove the pin for `urllib3` #507

Closed maxbelanger closed 2 months ago

maxbelanger commented 2 months ago

Now that CI works again and with the added tests, we can verify that certificate pinning does work with urllib3==2.

Fixes #506.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.70%. Comparing base (b474e21) to head (134b1cc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #507 +/- ## ========================================== - Coverage 64.26% 63.70% -0.56% ========================================== Files 31 31 Lines 53579 53579 Branches 3905 3905 ========================================== - Hits 34430 34133 -297 - Misses 18989 19412 +423 + Partials 160 34 -126 ``` | [Flag](https://app.codecov.io/gh/dropbox/dropbox-sdk-python/pull/507/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dropbox) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/dropbox/dropbox-sdk-python/pull/507/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dropbox) | `?` | | | [unit](https://app.codecov.io/gh/dropbox/dropbox-sdk-python/pull/507/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dropbox) | `63.70% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dropbox#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.