dropbox / dropbox-sdk-rust

Dropbox SDK for Rust
Apache License 2.0
76 stars 18 forks source link

Establish a MSRV (minimum supported Rust version) #113

Closed wfraser closed 2 years ago

wfraser commented 2 years ago

I used cargo-msrv to figure out what the current oldest rustc able to compile the project is, and it's 1.56.1, from October 2021. Going forward, I think it'd be good to ensure this is buildable using a Rust toolchain that's at least a year old.

This is motivated by Clippy adding lints for things that are only supported on fairly recent Rust. (In this case, it's inline variables in format strings.) We can disable those lints by adding a MSRV. Also it's just a good practice in general to be up-front about compiler support.

Checklist

General Contributing

Validation

I changed the GitHub tests to use the MSRV rust instead of the current Stable rust.