search

dropbox / godropbox

Common libraries for writing Go services/applications.
BSD 3-Clause "New" or "Revised" License
4.17k stars 428 forks source link

Net2 connectionPoolImpl Unregister not working #259

Closed maryryang2 closed 1 year ago

maryryang2 commented 1 year ago

Hi, I'm using a net2 ConnectionPool, which was created using NewMultiConnectionPool. I cannot Unregister connections after I Register them. It looks like connectionPoolImpl's Unregister function does not call the underlying Unregister function: https://github.com/dropbox/godropbox/blob/f0626942059b/net2/base_connection_pool.go#L114

Seems like the fix is pretty simple, but I don't have permission to create a new remote branch to submit a PR.

maryryang2 commented 1 year ago

Looks like I can just submit my fork for PR: https://github.com/dropbox/godropbox/pull/260