fix forgotten return in case of invalid line format from memcache ascii client

dropbox / godropbox

Common libraries for writing Go services/applications.

BSD 3-Clause "New" or "Revised" License

4.17k stars 427 forks source link

fix forgotten return in case of invalid line format from memcache ascii client #264

Open sivukhin opened 11 months ago

sivukhin commented 11 months ago

I ran govanish linter (it still in the WIP phase) against godropbox repo and it found one suspicious place:

2023/12/24 17:03:42 it seems like your code vanished from compiled binary: func=[Stat], file=[/home/sivukhin/code/godropbox/repo/memcache/raw_ascii_client.go], line=[675], snippet:
    NewStatErrorResponse(err, shardEntries)

Obviously, this is a bug - return statement were forgotten.

This PR fixes this bug.

CLAassistant commented 11 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}