search

dropbox / json11

A tiny JSON library for C++11.
MIT License
2.55k stars 616 forks source link

Add compatibility with older 2.8 version of CMake #107

Closed jcsilva closed 7 years ago

jcsilva commented 7 years ago

Some legacy systems (Ubuntu 14.04, RHEL7.2) have older versions of CMake.

smarx commented 7 years ago

Automated message from Dropbox CLA bot

@jcsilva, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

artwyman commented 7 years ago

I don't use CMake myself (it's a community-supported addition to this library) but I notice that your latest commit indicates removing version "temporarily". Do you plan further changes before proposing that this be merged?

amiasato-zz commented 7 years ago

Sorry for the hassle. The "temporary" commit was indeed a WIP, and the new commit should add compatibility with legacy CMake2.8 and avoid a CMake >=3.3 error of deprecated CMP0038 policy. As it stands, it looks good to go.

artwyman commented 7 years ago

You'll need to sign the CLA online before I can merge. I'm also curious if any CMake users such as @4brunu have any issue with this.

4brunu commented 7 years ago

I tested and it works here...

amiasato-zz commented 7 years ago

I have signed the CLA, but if it is the requester who needs to sign it, I can make a new pull request.

artwyman commented 7 years ago

@akira-miasato your name is on all the commits in the current version, which seems like it should be sufficient for legal purposes. The smarxbot won't check automatically for a non-submitter, but I just confirmed that your CLA response is logged.