dropbox / json11

A tiny JSON library for C++11.
MIT License
2.55k stars 616 forks source link

Tag Versioning #125

Closed scoopxyz closed 6 years ago

scoopxyz commented 6 years ago

Hello,

It would be great if this repo could use Tags to track versions :)

cdalvaro commented 6 years ago

With a tag versioning or a release version this pull request: homebrew-core/json11 could be approved!

artwyman commented 6 years ago

I think the core concern here is really just nobody wants to put unnecessary effort into versioning and release process for this repo. We don't need it at Dropbox, and aren't really changing this repo often, as you point out in the Homebrew thread. We pin commit hashes on all the external repos we use, which avoids the issue of pulling unexpected changes raised in that thread. I'm kinda surprised that Homebrew doesn't have the ability to do that and specify versions at the level of their tap config, rather than requiring tags in the repo.

I guess to make things easier on users I wouldn't be averse to simply slapping a 1.0 tag on the latest master. @j4cbo any thoughts?

cdalvaro commented 6 years ago

We pin commit hashes on all the external repos we use, which avoids the issue of pulling unexpected changes raised in that thread. I'm kinda surprised that Homebrew doesn't have the ability to do that and specify versions at the level of their tap config

Indeed this is what I'm done for the Homebrew formula, but it is not enough, so I need a tag version to fit the requirements.

class Json11 < Formula
desc "Tiny JSON library for C++11"
homepage "https://github.com/dropbox/json11"
url "https://github.com/dropbox/json11.git", :revision => "ec4e45219af1d7cde3d58b49ed762376fccf1ace"
version "1.0.0"

Your proposal of slapping a 1.0 tag to the latest master is OK for me!

j4cbo commented 6 years ago

I'm fine with calling the current master 1.0.0 :)

cdalvaro commented 6 years ago

So, there will finally be a 1.0.0 tag?

j4cbo commented 6 years ago

Just added one!