Generate pkg-config File & Add Install Target

dropbox / json11

A tiny JSON library for C++11.

MIT License

2.55k stars 615 forks source link

Generate pkg-config File & Add Install Target #53

Closed njwhite closed 8 years ago

njwhite commented 8 years ago

...to the CMake build script. The pkg-config file needs a version number (which it takes from the CMakeLists.txt variable), which I've set to 1.0.0. The cmake project declaration needs to be after the minimum-requirement declaration to avoid errors from the cmake's change in VERSION semantics.

smarx commented 8 years ago

Automated message from Dropbox CLA bot

@njwhite, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

njwhite commented 8 years ago

@smarx I've signed it now!

smarx commented 8 years ago

Automated message from Dropbox CLA bot

@njwhite, thanks for signing the CLA!

artwyman commented 8 years ago

We don't use CMake at Dropbox, so I haven't tested this. I seems like a good idea, though, so I'll trust you. If there are complaints from any other CMake users that this isn't the right approach, we can discuss more deeply.

njwhite commented 8 years ago

@artwyman thanks!