search

dropbox / json11

A tiny JSON library for C++11.
MIT License
2.55k stars 613 forks source link

[MSVC 14] int to bool conversion performance warning #68

Closed AustinBrunkhorst closed 8 years ago

AustinBrunkhorst commented 8 years ago

Compiling under MSVC 14 x64 with /W3 set gives the following warning.

warning C4800: 'int': forcing value to bool 'true' or 'false' (performance warning)

This commit fixes these warnings by explicitly converting the return value as a boolean.

artwyman commented 8 years ago

Thanks for the submission. I've made a suggestion to make the code cleaner/clearer. If you make that tweak I'm happy to merge this.

AustinBrunkhorst commented 8 years ago

I agree with your suggestion! I've pushed the changes. Thank you!