Closed admsyn closed 7 years ago
Automated message from Dropbox CLA bot
@admsyn, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.
The test output should be the same in either case. The difference should be that with the canary enabled, you should see an assertion failure on compilers which have the new/broken behavior. Your test run above seems to suggest that you didn't see that, though you mentioned seeing it in prior PR #71. Can you clarify?
I'm about to change the default to disabling the canary, so this should probably do the same if it's going to land.
Let me know if you want any more changes
Ah, sorry, I made the same mistake as last time, of looking only at the individual CLA spreadsheet, not the company one. You're all set.
This PR adds a cmake option for the DR 1467 tests, as described in PR #71
That said, the test output seems to be the same regardless. This is the output after applying this PR, with an extra debug line printed in the relevant canary section of the tests