Fix MSVC Compilation: Add MSVC warning flags

dropbox / json11

A tiny JSON library for C++11.

MIT License

2.55k stars 613 forks source link

Fix MSVC Compilation: Add MSVC warning flags #96

Closed jnguyen75 closed 7 years ago

jnguyen75 commented 7 years ago

When trying to build JSON11 on Microsoft Visual Studio 14 2015, the compiler would complain about the -Wextra and -Werror flags.

This PR adds a check for the C++ compiler before adding the compiler specific flags

smarx commented 7 years ago

Automated message from Dropbox CLA bot

@jnguyen75, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

artwyman commented 7 years ago

Hi @jnguyen75. Thanks for the PR.

This looks like a reasonable change, though since I don't use CMake I'd like to solicit feedback from someone who does, such as @4brunu.

Also, I'll need you to sign the CLA before I can merge anything.

4brunu commented 7 years ago

@artwyman Here it works fine

artwyman commented 7 years ago

Okay, changes approved. @jnguyen75 I just need you to sign the CLA so I can merge.

jnguyen75 commented 7 years ago

@artwyman my company representative has signed the CLA web form on my behalf. Could you confirm that you have received the signed CLA?

artwyman commented 7 years ago

Yep, the company CLA doesn't trigger the smarx-bot, since it doesn't get your GitHub username. I can confirm that we got a CLA entry from Amazon with your name listed @jnguyen75.