Disable build tests by default in CMake and enable them in make file

dropbox / json11

A tiny JSON library for C++11.

MIT License

2.55k stars 613 forks source link

Closed 4brunu closed 7 years ago

4brunu commented 7 years ago

This PR disable tests in the CMakeLists.txt and enable them in the Makefile with the option JSON11_BUILD_TESTS.

This will make the integration of json11 on other projects with CMake easier, especially on iOS, since it crashes it the tests are enabled. http://stackoverflow.com/questions/37880180/error-creating-ios-static-library-using-cmake

smarx commented 7 years ago

Automated message from Dropbox CLA bot

@4brunu, it looks like you've already signed the Dropbox CLA. Thanks!

4brunu commented 7 years ago

@artwyman I reverted the Makefile as you suggested. If you have any more suggestions please let me know.