search

dropbox / kaiken

User scoping library for Android applications.
Apache License 2.0
69 stars 11 forks source link

Remove BuildConfig.DEBUG for AuthHelperStore #153

Closed chris-mitchell closed 2 years ago

chris-mitchell commented 2 years ago

BuildConfig.DEBUG is hard coded to false when we release to Maven.

If consumers use this, they won't be able to override for their tests as it in a release.

I think this does give the option that a consumer also abuses this functionality at runtime and uses it in production, but we'd need to refactor some code and extract things into another scoping-test-util module or similar.

chris-mitchell commented 2 years ago

Relates to https://github.com/dropbox/kaiken/pull/64