search

dropbox / kaiken

User scoping library for Android applications.
Apache License 2.0
69 stars 11 forks source link

Fix generator to allow scopes outside classpath and multiple bindings #169

Closed joshafeinberg closed 2 years ago

joshafeinberg commented 2 years ago

This PR fixes two issues

  1. Previously, when using Class.forName in the generator, if the scope wasn't in the classpath the generator would fail. This meant you could not provide custom scopes and only use the ones built into kaiken
  2. Anvil has an issue with multiple @ContributesTo bindings existing for the same class. This moves the generator to build out separate classes until we update to the latest version of Anvil (https://github.com/square/anvil/issues/236) which should now support this without the multiple class hack