search

dropbox / lepton

Lepton is a tool and file format for losslessly compressing JPEGs by an average of 22%.
https://blogs.dropbox.com/tech/2016/07/lepton-image-compression-saving-22-losslessly-from-images-at-15mbs/
Apache License 2.0
5.01k stars 355 forks source link

Executing in Windows 7 #39

Closed rtalon83 closed 8 years ago

rtalon83 commented 8 years ago

lepton v1.0-08c52d9280df3d409d9246df7ff166dd94628730 Failed To start subprocess with command line OS_ERROR

Maxime-J commented 8 years ago

Also got that one on Windows 10 in two scenarios: -When lepton is called without .exe lepton file.jpg => Failed To start subprocess with command line OS_ERROR -When lepton is included in path and called from another directory lepton.exe file.jpg => Failed To start subprocess with command line OS_ERROR

danielrh commented 8 years ago

Does this happen if you drag and drop a file onto the eye?

danielrh commented 8 years ago

I mean exe

Maxime-J commented 8 years ago

No problem with drag and drop.

danielrh commented 8 years ago

ya I don't know what the difference is between drag and drop and the other--but for now can you just use drag + drop?

Maxime-J commented 8 years ago

Interesting to note that there isn't this problem via powershell. Via cmd, you would have to include lepton in the working dir and call it with .exe. For now, that's fine for me.

I just hope that rtalon83 problem was the same because I kinda took over his issue . @rtalon83 You confirm that it works when you call it with .exe or with a drag and drop?

rtalon83 commented 8 years ago

Yes, it works with a drag and drop. thk!

Text-Mode commented 7 years ago

Just ran into this problem on Windows 7. The problem seems to be the argv[0] parameter in CreateProcess of the start_subprocess method (io_util.cc). If this is the full path and .exe then it works, otherwise OS_ERROR. Maybe wise to call GetFullPathName on argv[0] prior to calling CreateProcess.