search

dropbox / lepton

Lepton is a tool and file format for losslessly compressing JPEGs by an average of 22%.
https://blogs.dropbox.com/tech/2016/07/lepton-image-compression-saving-22-losslessly-from-images-at-15mbs/
Apache License 2.0
5.01k stars 355 forks source link

Revert "close opened file descriptors properly" #62

Closed fxrlv closed 8 years ago

fxrlv commented 8 years ago

Reverts dropbox/lepton#60

Added fclose causes SIGSEGV on some OS, because fp, which is arg for fclose, in this context always is NULL.

bryonglodencissp commented 8 years ago

Nice! @AlexanderFrolov and co, it's worth noting that we've done extensive studies, and 60% of the time our static analysis tool works all the time. Furthermore, sound and complete static analysis is shown to be undecidable, ergo we're led to a few false positives because we've adopted some unsound techniques in our tool. 👍

With that said, here is another explanation on why fclose(NULL) is causing a segmentation fault on some OS.