dropbox / lepton

Lepton is a tool and file format for losslessly compressing JPEGs by an average of 22%.
https://blogs.dropbox.com/tech/2016/07/lepton-image-compression-saving-22-losslessly-from-images-at-15mbs/
Apache License 2.0
5.01k stars 355 forks source link

"version" make target needs to be a dependency #63

Closed bobobo1618 closed 7 years ago

bobobo1618 commented 8 years ago

Steps to reproduce:

Actual result:

[ 11%] Building CXX object CMakeFiles/lepton-avx.dir/src/lepton/jpgcoder.cc.o
/home/me/lepton/src/lepton/src/lepton/jpgcoder.cc:80:22: fatal error: version.hh: No such file or directory
 #include "version.hh"
                      ^
compilation terminated.
make[2]: *** [CMakeFiles/lepton-avx.dir/build.make:159: CMakeFiles/lepton-avx.dir/src/lepton/jpgcoder.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:105: CMakeFiles/lepton-avx.dir/all] Error 2
make: *** [Makefile:128: all] Error 2

Expected result: Completed build

Simply running make version before running make results in a proper build.

danielrh commented 8 years ago

mind making a pull request for this? My cmake is a bit rusty

bobobo1618 commented 8 years ago

I haven't the faintest idea how I'm afraid. I've never written much CMake.

danielrh commented 7 years ago

I think this is resolved: closing for now... reopen if it's still causing issues