dropbox / lepton

Lepton is a tool and file format for losslessly compressing JPEGs by an average of 22%.
https://blogs.dropbox.com/tech/2016/07/lepton-image-compression-saving-22-losslessly-from-images-at-15mbs/
Apache License 2.0
5.01k stars 355 forks source link

Lepton version doesn't show properly #80

Closed C0rn3j closed 7 years ago

C0rn3j commented 7 years ago

Using package from AUR (Which likely isn't an issue, PKGBUILD doesn't seem to do anything with the version).

c0rn3j@c0rn3jDesktop  ~  lepton lepton v1.0-

✘ c0rn3j@c0rn3jDesktop  ~  lepton -version 01

I'd imagine it'd show 1.2.1 somewhere?

danielrh commented 7 years ago

right now the version 1.0 is more centered around the file format version. I think if you actually run a conversion it shows the git hash or a properly built package hash? which apparently wasn't set for that package build....if you look at the packages in the release here I believe the version is actually computed this way using cmake


=${PROJECT_SOURCE_DIR} rev-parse HEAD                                           
     OUTPUT_VARIABLE VERSION                                                    
     OUTPUT_STRIP_TRAILING_WHITESPACE  ```

and this way 
```-DGIT_REVISION=\"$(shell git describe --dirty --always 2> /dev/null || basename `pwd`)\"```
using configure