Closed coxley closed 1 year ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
The other PR had become very old and was using a fork of the real deal.
Implements #83
Events are created for each create, update, delete action on each resource. These events are published on-save for the Change model.
All hooks will be matched with the event and not the default "user who made change" -> "user's hooks". I think this makes sense due to the nature of an IPAM and assuming people will want to subscribe to all changes for a category, not just changes made by a specific user to the category.
There's no retrying here. We can always reiterate on that later but the framework doesn't implement it themselves. You can involve celery tasks to do it (as the authors want you to) or overload the delivery function and deal with making sure it's threaded/asyncio/otherwise non-blocking.
I've tested and they definitely work. Example of update for a hook for user
1
when the change was made by user2
:The NSoT tests are kind of hard to follow for implementing a new endpoint. Mostly because there are so many custom wrappers/utils and I'm not sure what I need to/should re-implement for the new one. Could use suggestions here.
My testing of the hooks was very easy via the API explorer.