Interface Tree traversal

dropbox / nsot

Network Source of Truth is an open source IPAM and network inventory database

https://nsot.readthedocs.io

Other

399 stars 66 forks source link

Closed rmhasan closed 7 years ago

rmhasan commented 7 years ago

Added following methods in InterfaceViewSet which can be invoked by get requests to return view sets

Also implemented following methods in Interface model class in models.py which get invoked in the view methods

Also added tests in tests/api_tests/test_interfaces.py and tests/model_tests/test_interfaces.py

jathanism commented 7 years ago

Oh awesome. Sorry I've been behind the curve. I'll check this out. Thank you!!

jathanism commented 7 years ago

I'm going to review this damn thing eventually. I need a clone.

rmhasan commented 7 years ago

Hi @jathanism and @nickpegg, I saw the feed back on #266 and #271. I will work on them soon.

rmhasan commented 7 years ago

Hi @jathanism and @nickpegg I worked on the changes you requested. Sorry it took so long.

jathanism commented 7 years ago

@rmhasan There's no need to apologize, you're a hero!

rmhasan commented 7 years ago

Hi @jathanism and @nickpegg. I made the following changes.

use self.retreive to return parent and root interfaces
change filter query for siblings view to look for interfaces with same parent and device
return Interface whose parent is None as root if root is called on that interface
also added validation check to prevent users from setting an interfaces parent to a interface with a different device
added test to check when siblings is called, that interfaces with same parent and devices are returned
added test to check when root is called on an interface with no parent that it is returned
added test to check that a user cannot set an interface's parent to an interface with different device

EDIT: You can also checkout PR dropbox/pynsot#134 to test the new tree traversal methods.

rmhasan commented 7 years ago

Hi @jathanism I made the following changes

I modified the docstrings of some functions and added docstrings to others
I changed the message in the ValidationError thrown from Interface.clean_parent to be a double quoted string
Instead of returning lists, I'm returning Querysets from Interface.get_descendants, Interface.get_ancestors, and Interface.get_siblings

nickpegg commented 7 years ago

Thanks for this contribution! :) I'm merging this and cutting a new version. I'll drop a note on this PR once that version's available on PyPI.

nickpegg commented 7 years ago