Iterables Feature Request - Expanded

dropbox / nsot

Network Source of Truth is an open source IPAM and network inventory database

https://nsot.readthedocs.io

Other

399 stars 66 forks source link

Iterables Feature Request - Expanded #302

Open dirtyonekanobi opened 6 years ago

dirtyonekanobi commented 6 years ago

This pr expounds on terlmen0's PR #218 (with permission) - but makes the following changes:

Instead of implementing a separate model for Iterables/Itervalues, we take an approach similar to the way Networks handle adjacencies.
Parent/children of iterables are in the same model
introduced a 'value' to the Iterables model
Iterables are now a Resource and can be queried using attributes
adjusted the get_next_value() iterable method to account for children

Please feel free to suggest any changes. Thank you!

jathanism commented 6 years ago

@dirtyonekanobi Just taking a look at this now. Thank you so much for contributing.

jathanism commented 6 years ago

Hey let's keep this moving! Let's get this updated for the latest release and get the tests working.

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Daryn Johnson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}