dropbox / nsot

Network Source of Truth is an open source IPAM and network inventory database
https://nsot.readthedocs.io
Other
399 stars 66 forks source link

Bug in circuit create serializer: Doesn't include the "site" field. #303

Open jathanism opened 6 years ago

jathanism commented 6 years ago

This isn't caught because we have few use-cases that include top-level objects that aren't using site-specific API endpoints. We are not testing for this either.

e.g. POST /api/circuits/ is hardly tested if at all, while POST /api/sites/1/circuits/ is the bulk of our testing. I'm pretty certain that a test in the former case would fail with an error about missing site (site_id) since this value passed in implicitly in the latter example (more common).

So this isn't an active bug, but it's one I noted while working on the Protocol feature.