search

dropbox / nsot

Network Source of Truth is an open source IPAM and network inventory database
https://nsot.readthedocs.io
Other
399 stars 66 forks source link

Remove django-smart-selects from requirements. #320

Closed jathanism closed 6 years ago

jathanism commented 6 years ago

This dependency is no longer necessary. The database migrations that referenced the ChainedForeignKey field were updated to swap it with a regular ForeignKey field.

While it sounds bad, underneath the ChainedForeignKey field was still just an FK with extra app-level behavior so reverting it to FK is really a no-op from the perspective of the underlying db schema.

narJH27 commented 6 years ago

I just wanted to know what prompted this change? Also, this change me essentially be a no-op from a DB schema, but with the extra app-level behavior now gone with this PR, do we expect any functionality to break?

jathanism commented 6 years ago

@narJH27 This is in preparation for v2. We are not using the ChainedForeignKey functionality at all, so it was extraneous and was simply a basic ForeignKey. No functionality will break and the tests passing proves that. :)