dropbox / nsot

Network Source of Truth is an open source IPAM and network inventory database
https://nsot.readthedocs.io
Other
399 stars 66 forks source link

Remove bower from frontend build process #361

Closed ryanheffernan closed 5 years ago

ryanheffernan commented 5 years ago

bower has been deprecated and also contains at least one serious vulnerability, so I'd say it's about time to get rid of it and use an alternate tool to handle our web dependencies.

Some quick googling indicates that yarn and npm are the most common tools people are using in place of bower. Given that we already use NPM for the dev dependencies I think it makes sense to just stick with that vs add a new tool into the build chain. This also has the advantage of allowing us to consolidate both dev and web deps into one file (package.json).

Removing bower meant that a few pieces of the build process had to be changed:

I verified I could use the UI to create/delete/view various objects and observed no errors in the server logs.