search

dropbox / pb-jelly

A protobuf code generation framework for the Rust language developed at Dropbox.
Apache License 2.0
610 stars 25 forks source link

Add a Github Action for clippy #134

Closed cyang1 closed 2 years ago

cyang1 commented 2 years ago

Not sure if this works as written, hopefully it's possible to test out in a PR.

Will go through and fix all the lints before landing. Feel free to bikeshed clippy arguments.

cyang1 commented 2 years ago

Ah hmm, I'm not sure if this can run on generated code, or what it would look like if it did (given that it posts comments onto the diff itself, and those files aren't in the repo).

nipunn1313 commented 2 years ago

we can make a PR to add generated fioles to the repo so that this sort of thing works.

Alternately - you can generate them in the first step of the clippy project. Whatever you feel like

cyang1 commented 2 years ago

Updated to generate in the clippy action, but still not sure what it will look like.

ParkMyCar commented 2 years ago

Shoot I totally missed this, I also added a workflow in #136. I'm happy to land whichever 🙂

cyang1 commented 2 years ago

Looks like #136 is merged, so I'm fine with closing this. This one adds the Github action that posts comments back on the PR, but I'm not sure how well it works with the multiple crate structure in this repo anyhow.