Drop Python2 Compatibility

dropbox / pb-jelly

A protobuf code generation framework for the Rust language developed at Dropbox.

Apache License 2.0

611 stars 25 forks source link

Drop Python2 Compatibility #40

Closed nipunn1313 closed 4 years ago

nipunn1313 commented 4 years ago

Inline the mypy annotations Remove reference to six library

We should wait until python2 end-of-lifes before completing this task!

joshuawarner32 commented 4 years ago

Isn't python2 already EOL'd? https://www.python.org/doc/sunset-python-2/

nipunn1313 commented 4 years ago

ah whoops! I somehow (incorrectly) thought it EOL'd at the end of the year. Thanks for the clarification. I suppose then the last remaining blocker is to make sure DBX internal usage is all py3!

flying-sheep commented 4 years ago

The pb-jelly-gen readme also still talks about a “python2 script”: https://github.com/dropbox/pb-jelly/blob/master/pb-jelly-gen/README.md

nipunn1313 commented 4 years ago

Thanks for pointing that out. I believe that reference has been removed now.

nipunn1313 commented 4 years ago

DBX internal usage is now all py3 - so we can do this! I think we should wait until we get CI set up (#43) - but otherwise looking good

nipunn1313 commented 4 years ago

This is done with #64 and #65